Bug 203244

Summary: [GTK][WPE] Fix non-unified builds after r251326
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, cgarcia, clopez, commit-queue, dbates, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, hi, joepeck, jsbell, kangil.han, keith_miller, mark.lam, msaboff, rniwa, saam, tzagallo, webkit-bug-importer, wenson_hsieh, youennf, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2019-10-22 05:40:08 PDT
Another weekly batch of fixups for non-unified builds :-}
Attachments
Patch (12.80 KB, patch)
2019-10-22 06:23 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2019-10-22 06:23:34 PDT
Created attachment 381539 [details] Patch
youenn fablet
Comment 2 2019-10-22 06:27:04 PDT
Comment on attachment 381539 [details] Patch r=me once bots are happy. It would be great to have an EWS bot building non unified.
Adrian Perez
Comment 3 2019-10-22 08:10:27 PDT
(In reply to youenn fablet from comment #2) > Comment on attachment 381539 [details] > Patch > > r=me once bots are happy. The “ios-wk2” test which fails is not new, it has been there for a few builds; same for the flaky ones. The issue with the “wincairo” build is the intermittent failure to clean up temporary files at the time of applying the patch. It looks safe to cq+ this :) > It would be great to have an EWS bot building non unified. Agreed. Let's see if I can manage to “borrow“ some time from something else in the coming weeks for that.
WebKit Commit Bot
Comment 4 2019-10-22 09:39:04 PDT
Comment on attachment 381539 [details] Patch Clearing flags on attachment: 381539 Committed r251436: <https://trac.webkit.org/changeset/251436>
WebKit Commit Bot
Comment 5 2019-10-22 09:39:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-10-22 09:40:18 PDT
<rdar://problem/56502978>
Note You need to log in before you can comment on or make changes to this bug.