Summary: | Resource Load Statistics: Update cookie blocking in NetworkStorageSession after first user interaction | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Wilander <wilander> | ||||||||
Component: | WebKit Misc. | Assignee: | John Wilander <wilander> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
John Wilander
2019-10-21 09:13:53 PDT
Created attachment 381420 [details]
Patch
Created attachment 381433 [details]
Patch
Cc'ing Chris for him to take a look at the innerCompletionHandler part. Comment on attachment 381433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381433&action=review LGTM with 1 nit. > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:551 > + postTaskReply([completionHandler = WTFMove(completionHandler)]() mutable { Doesn't postTaskReply(WTFMove(completionHandler)); work? (In reply to Chris Dumez from comment #5) > Comment on attachment 381433 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381433&action=review > > LGTM with 1 nit. > > > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:551 > > + postTaskReply([completionHandler = WTFMove(completionHandler)]() mutable { > > Doesn't postTaskReply(WTFMove(completionHandler)); work? I actually started that way then reviewed how we've done it previously. I'll switch to that. Thanks both of you! Created attachment 381448 [details]
Patch for landing
Comment on attachment 381448 [details] Patch for landing Clearing flags on attachment: 381448 Committed r251391: <https://trac.webkit.org/changeset/251391> All reviewed patches have been landed. Closing bug. |