Bug 203191

Summary: [GTK] C++ comments used in C header files
Product: WebKit Reporter: Milan Crha <mcrha>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, ews-watchlist, gustavo, zan
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Milan Crha
Reported 2019-10-21 03:20:07 PDT
I just tried to compile Evolution with -ansi -D_DEFAULT_SOURCE=1 and I see a lot of warnings coming from WebKitGTK+ like this: /usr/include/webkitgtk-4.0/webkit2/WebKitAutocleanups.h:88:8: warning: extra tokens at end of #endif directive [-Wendif-labels] 88 | #endif // WebKitAutocleanups_h There are a lot of these, from various files. The fix is to use C comments, thus: #endif /* WebKitAutocleanups_h */
Attachments
Patch (6.96 KB, patch)
2019-10-21 04:42 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-10-21 04:42:24 PDT
Created attachment 381412 [details] Patch
EWS Watchlist
Comment 2 2019-10-21 04:43:12 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2019-10-22 01:48:31 PDT
Committed r251423: <https://trac.webkit.org/changeset/251423>
Note You need to log in before you can comment on or make changes to this bug.