Bug 203185

Summary: Closing a MiniBrowser WK2 window does not release the WKWebView
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2019-10-19 20:45:13 PDT
I noticed that video keeps playing after closing its containing MiniBrowser window. We never hit -[WKWebView dealloc]. Need to figure out who's keeping it alive.
Attachments
Patch (1.59 KB, patch)
2020-02-01 12:51 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-02-01 12:43:10 PST
This is creating a retain cycle: _textFinder.hideInterfaceCallback = ^{ [_webView _hideFindUI]; };
Simon Fraser (smfr)
Comment 2 2020-02-01 12:51:56 PST
Created attachment 389465 [details] Patch
WebKit Commit Bot
Comment 3 2020-02-01 14:26:39 PST
Comment on attachment 389465 [details] Patch Clearing flags on attachment: 389465 Committed r255543: <https://trac.webkit.org/changeset/255543>
WebKit Commit Bot
Comment 4 2020-02-01 14:26:40 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-02-01 14:27:17 PST
<rdar://problem/59090239>
Tim Horton
Comment 6 2020-02-01 23:08:29 PST
There's a warning for that that we should consider turning on!
Note You need to log in before you can comment on or make changes to this bug.