Bug 203175

Summary: macCatalyst: Cursor should send mouse events, not touch events
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, ews-watchlist, graouts, kangil.han, megan_gardner, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2019-10-18 17:28:36 PDT
macCatalyst: Cursor should send mouse events, not touch events
Attachments
Patch (37.33 KB, patch)
2019-10-18 17:29 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (37.37 KB, patch)
2019-10-18 17:53 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (37.39 KB, patch)
2019-10-18 18:22 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (37.38 KB, patch)
2019-10-18 18:23 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-10-18 17:29:14 PDT
Created attachment 381353 [details] Patch
Tim Horton
Comment 2 2019-10-18 17:29:18 PDT
<rdar://problem/56321134>
Tim Horton
Comment 3 2019-10-18 17:53:22 PDT
Created attachment 381358 [details] Patch
Simon Fraser (smfr)
Comment 4 2019-10-18 18:03:35 PDT
Comment on attachment 381358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381358&action=review > Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:57 > + Optional<WebKit::NativeWebMouseEvent> _lastEvent; std::unique_ptr<>? > Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:146 > + auto timestamp = WallTime::fromRawSeconds(GSCurrentEventTimestamp() / 1000000000.0); Don't we have a nanosecondsToMumble?
Tim Horton
Comment 5 2019-10-18 18:22:35 PDT
Created attachment 381359 [details] Patch
Tim Horton
Comment 6 2019-10-18 18:23:56 PDT
Created attachment 381360 [details] Patch
WebKit Commit Bot
Comment 7 2019-10-18 22:48:21 PDT
Comment on attachment 381360 [details] Patch Clearing flags on attachment: 381360 Committed r251320: <https://trac.webkit.org/changeset/251320>
WebKit Commit Bot
Comment 8 2019-10-18 22:48:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.