Summary: | texImage2d fails to set same video frame to multiple textures | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Taylor <simontaylor1> | ||||||||||
Component: | WebGL | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | darin, dino, eric.carlson, evodabas, ews-watchlist, glenn, jer.noble, justin_fan, kkinnunen, kondapallykalyan, marcus.stenbeck, philipj, sergio, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Safari 13 | ||||||||||||
Hardware: | All | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=231031 | ||||||||||||
Attachments: |
|
Description
Simon Taylor
2019-10-18 02:43:07 PDT
Created attachment 381291 [details]
Example page
There is a hosted example here for testing purposes: https://tango-bravo.net/webkit-bug-203148/index.html This works fine on Chrome, and shows the broken behaviour in Safari 13 on both MacOS and iOS. Just wanted to chime in that we're running into this issue as well. Thanks for the report. I can confirm the issue. *** Bug 234230 has been marked as a duplicate of this bug. *** Created attachment 449655 [details]
Patch
Created attachment 449664 [details]
Patch
Comment on attachment 449664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449664&action=review > Source/WebCore/platform/graphics/cv/GraphicsContextGLCVCocoa.cpp:611 > + if (it != m_knownContent.end()) { > + if (it->value == content) { Use && instead of nesting? > Source/WebCore/platform/graphics/cv/GraphicsContextGLCVCocoa.h:71 > + // TODO: Switch back to UnsafePointer<IOSurfaceRef> once UnsafePointer is safe to compare. WebKit style uses FIXME for this. Means the same as TODO. > Source/WebCore/platform/graphics/cv/GraphicsContextGLCVCocoa.h:81 > + bool operator==(const TextureContent& other) const; Remove the name "other" please. I also think you might want to add a blank line above this. Created attachment 449786 [details]
Patch for landing
Committed r288434 (246323@main): <https://commits.webkit.org/246323@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449786 [details]. As a note for people watching this for information on when the fix lands in iOS Safari - this is fixed in iOS 15.4 beta 4. |