Bug 203128

Summary: Remove IDBBackingStoreTemporaryFileHandler
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, commit-queue, ews-watchlist, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Sihui Liu
Reported 2019-10-17 17:08:53 PDT
IDBBackingStoreTemporaryFileHandler has only one member function, and implementation of that is to delete files. We can remove this class and delete the temporary files at the places where objects of this class are used. By doing this, we no longer need to pass the NetworkProcess/InProcessIDBServer all the way down to SQLiteIDBBackingStore, which leads to cross-thread copying.
Attachments
Patch (18.68 KB, patch)
2019-10-17 17:16 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.69 KB, patch)
2019-10-21 15:51 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-10-17 17:16:41 PDT
Created attachment 381253 [details] Patch
Sihui Liu
Comment 2 2019-10-21 15:51:38 PDT
Created attachment 381470 [details] Patch for landing
WebKit Commit Bot
Comment 3 2019-10-21 17:53:28 PDT
Comment on attachment 381470 [details] Patch for landing Clearing flags on attachment: 381470 Committed r251404: <https://trac.webkit.org/changeset/251404>
WebKit Commit Bot
Comment 4 2019-10-21 17:53:29 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-10-21 17:54:15 PDT
<rdar://problem/56484333>
Note You need to log in before you can comment on or make changes to this bug.