Bug 203125

Summary: Only include "deep color" in layer tree dumps if a tests requests it
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, fred.wang, glenn, jbedard, kondapallykalyan, pdr, sergio, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Simon Fraser (smfr)
Reported 2019-10-17 15:54:02 PDT
Only include "deep color" in layer tree dumps if a tests requests it
Attachments
Patch (20.25 KB, patch)
2019-10-17 15:55 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-10-17 15:55:34 PDT
Created attachment 381243 [details] Patch
Tim Horton
Comment 2 2019-10-17 16:00:57 PDT
Comment on attachment 381243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381243&action=review > Source/WebCore/testing/Internals.h:374 > + LAYER_TREE_INCLUDES_DEEP_COLOR = 1024, Why is this not bit shifts! > Source/WebCore/testing/Internals.idl:401 > + const unsigned short LAYER_TREE_INCLUDES_DEEP_COLOR = 1024; Maybe this is why
Simon Fraser (smfr)
Comment 3 2019-10-17 21:24:42 PDT
https://trac.webkit.org/changeset/251273/webkit
Radar WebKit Bug Importer
Comment 4 2019-10-17 21:25:39 PDT
<rdar://problem/56396406>
Note You need to log in before you can comment on or make changes to this bug.