Bug 203125

Summary:

Only include "deep color" in layer tree dumps if a tests requests it

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

esprehn+autocc, ews-watchlist, fred.wang, glenn, jbedard, kondapallykalyan, pdr, sergio, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Simon Fraser (smfr) 2019-10-17 15:54:02 PDT

Only include "deep color" in layer tree dumps if a tests requests it

Comment 1 Simon Fraser (smfr) 2019-10-17 15:55:34 PDT

Created attachment 381243 [details]
Patch

Comment 2 Tim Horton 2019-10-17 16:00:57 PDT

Comment on attachment 381243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381243&action=review

> Source/WebCore/testing/Internals.h:374
> +        LAYER_TREE_INCLUDES_DEEP_COLOR = 1024,

Why is this not bit shifts!

> Source/WebCore/testing/Internals.idl:401
> +    const unsigned short LAYER_TREE_INCLUDES_DEEP_COLOR = 1024;

Maybe this is why

Comment 3 Simon Fraser (smfr) 2019-10-17 21:24:42 PDT

https://trac.webkit.org/changeset/251273/webkit

Comment 4 Radar WebKit Bug Importer 2019-10-17 21:25:39 PDT

<rdar://problem/56396406>