| Summary: | [ews] status bubbles should show details from all the builds in case build is retried | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-10-17 12:04:04 PDT
Created attachment 381215 [details]
Patch
Sample run: https://ews.webkit-uat.org/status-bubble/380828/ Notice that services bubble is listing all the retried builds. Comment on attachment 381215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381215&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:189 > + message += '\n\n' + self._steps_messages(build) How long can this get? Looking at your example, the tooltip is totally reasonable, but it seems like we don't actually have a limit on how many builds you have here (In reply to Jonathan Bedard from comment #3) > > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:189 > > + message += '\n\n' + self._steps_messages(build) > > How long can this get? We are not limiting anything currently. > > Looking at your example, the tooltip is totally reasonable, but it seems like we don't actually have a limit on how many builds you have here We can have the problem of too much text even with a single build. Not sure what's a good limit to put. Maybe we can land this patch as is, and see if and how exactly do we hit this issue of too much text, and then solve it appropriately. Comment on attachment 381215 [details] Patch Clearing flags on attachment: 381215 Committed r251256: <https://trac.webkit.org/changeset/251256> All reviewed patches have been landed. Closing bug. Deployed in production. |