Bug 203114

Summary:

Remove unused WKWebsiteDataStore setter SPI

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Description Alex Christensen 2019-10-17 11:14:48 PDT

Remove unused WKWebsiteDataStore setter SPI

Comment 1 Alex Christensen 2019-10-17 11:15:28 PDT

Created attachment 381203 [details]
Patch

Comment 2 Alex Christensen 2019-10-17 11:19:32 PDT

Comment on attachment 381203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381203&action=review

> Source/WebKit/ChangeLog:8
> +        They have been replaced by _WKWebsiteDataStoreConfiguration SPI which was adopted in rdar://problem/56349165

I'll wait for this radar to be integrated before landing.

Comment 3 Alex Christensen 2019-10-28 14:52:22 PDT

http://trac.webkit.org/r251675

Comment 4 Radar WebKit Bug Importer 2019-10-28 14:53:19 PDT

<rdar://problem/56686031>

Comment 5 Alex Christensen 2019-10-28 17:10:21 PDT

Comment on attachment 381203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381203&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:-56
> -@property (nonatomic, setter=_setAllowsCellularAccess:) BOOL _allowsCellularAccess WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration.allowsCellularAccess", macos(10.13.4, WK_MAC_TBA), ios(11.3, WK_IOS_TBA));

Somebody's still using this.  Grumble grumble.  Will not break their build again.