Summary: | DatabaseContext should not prevent entering the back/forward cache | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, ggaren, ryanhaddad, sihui_liu, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=206291 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 202293 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2019-10-17 09:56:10 PDT
*** Bug 159379 has been marked as a duplicate of this bug. *** Created attachment 381841 [details]
Patch
Comment on attachment 381841 [details]
Patch
r=me
The commit-queue encountered the following flaky tests while processing attachment 381841 [details]:
The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 381841 [details]: imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003-visual.svg bug 203172 (author: sabouhallawa@apple.com) fast/history/page-cache-webdatabase-pending-transaction.html bug 203399 (author: cdumez@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 381841 [details] Patch Clearing flags on attachment: 381841 Committed r251586: <https://trac.webkit.org/changeset/251586> All reviewed patches have been landed. Closing bug. Reverted r251586 for reason: New test is flaky Committed r251592: <https://trac.webkit.org/changeset/251592> Looks like queueing JS callbacks in not sufficient because Database threads currently get terminated on navigation and may therefore not have time to schedule their callbacks: 1 0x7243d44e1 WTF::MessageQueue<WebCore::DatabaseTask>::kill() 2 0x7243d0ac4 WebCore::DatabaseThread::requestTermination(WebCore::DatabaseTaskSynchronizer*) 3 0x7243d0988 WebCore::DatabaseContext::stopDatabases(WebCore::DatabaseTaskSynchronizer*) 4 0x7243d2be3 WebCore::DatabaseManager::stopDatabases(WebCore::Document&, WebCore::DatabaseTaskSynchronizer*) 5 0x7256d2e39 WebCore::FrameLoader::stopLoading(WebCore::UnloadEventPolicy) Created attachment 382042 [details]
Patch
Created attachment 382095 [details]
Patch
ping review? ping review? Comment on attachment 382095 [details]
Patch
r=me
Pretty sure WebDatabase is fully disabled these days, so I guess this is an example of why it would be good to remove the code entirely soon.
Comment on attachment 382095 [details] Patch Clearing flags on attachment: 382095 Committed r252064: <https://trac.webkit.org/changeset/252064> All reviewed patches have been landed. Closing bug. |