| Summary: | MediaKeySession / WebKitMediaKeySession should not prevent entering the back/forward cache | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
| Component: | Media | Assignee: | Chris Dumez <cdumez> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | calvaris, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kondapallykalyan, philipj, sergio, tsavell, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 202293 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Chris Dumez
2019-10-17 09:42:14 PDT
Created attachment 382392 [details]
WIP Patch
Created attachment 382395 [details]
WIP Patch
Created attachment 382457 [details]
Patch
ping review? Comment on attachment 382457 [details]
Patch
How do we make sure we have not missed to enqueue one event or a task?
We probably do not have a lot of coverage there.
(In reply to youenn fablet from comment #6) > Comment on attachment 382457 [details] > Patch > > How do we make sure we have not missed to enqueue one event or a task? > We probably do not have a lot of coverage there. If you try to dispatch events while in the cache, then we would hit assertions. Comment on attachment 382457 [details] Patch Clearing flags on attachment: 382457 Committed r251993: <https://trac.webkit.org/changeset/251993> All reviewed patches have been landed. Closing bug. The changes in https://trac.webkit.org/changeset/251993/webkit broke platform/mac/media/encrypted-media/fps-generateRequest.html History: https://results.webkit.org/?suite=layout-tests&test=platform%2Fmac%2Fmedia%2Fencrypted-media%2Ffps-generateRequest.html Diff: --- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/platform/mac/media/encrypted-media/fps-generateRequest-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/platform/mac/media/encrypted-media/fps-generateRequest-actual.txt @@ -6,6 +6,6 @@ RUN(session = keys.createSession()) EXPECTED (session != 'null') OK RUN(promise = session.generateRequest("sinf", initData)) -Promise resolved OK +Promise rejected FAIL END OF TEST Reverted r251993 for reason: Broke platform/mac/media/encrypted-media/fps-generateRequest.html on Mojave+ Committed r252008: <https://trac.webkit.org/changeset/252008> Created attachment 382787 [details]
Patch
Comment on attachment 382787 [details] Patch Rejecting attachment 382787 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 382787, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13212916 Created attachment 382795 [details]
Patch
Comment on attachment 382795 [details] Patch Clearing flags on attachment: 382795 Committed r252033: <https://trac.webkit.org/changeset/252033> All reviewed patches have been landed. Closing bug. |