Bug 203078

Summary: [MSE][GStreamer] Revert WebKitMediaSrc rework temporarily
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, calvaris, cgarcia, clopez, commit-queue, eric.carlson, ews-watchlist, glenn, gustavo, gyuyoung.kim, jbedard, jer.noble, menard, philipj, pnormand, rakuco, ryuan.choi, sergio, vjaquez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2019-10-17 01:23:09 PDT
While the WebKitMediaSrc rework fixed a number of tests and introduced design improvements in MSE, it also exposed a number of bugs related to the playbin3 switch. Fixing these has been turned tricky, so in order to not keep known user-facing bugs, I'm reverting it for now until a workable solution is available.
Attachments
Patch (167.45 KB, patch)
2019-10-17 03:54 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2019-10-17 03:54:51 PDT
Created attachment 381188 [details] Patch
Carlos Alberto Lopez Perez
Comment 2 2019-10-17 04:56:41 PDT
Is this related to bug 201824 ? Is GStreamer 1.16 still required for MSE after this patch?
Alicia Boya García
Comment 3 2019-10-18 08:34:50 PDT
(In reply to Carlos Alberto Lopez Perez from comment #2) > Is this related to bug 201824 ? Is GStreamer 1.16 still required for MSE > after this patch? It will be no longer required. But once the issues are fixed and a new iteration landed it will be required again (either that or 1.14 with appropriate backport patches).
WebKit Commit Bot
Comment 4 2019-10-21 06:28:57 PDT
Comment on attachment 381188 [details] Patch Clearing flags on attachment: 381188 Committed r251365: <https://trac.webkit.org/changeset/251365>
WebKit Commit Bot
Comment 5 2019-10-21 06:29:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.