Bug 203078 - [MSE][GStreamer] Revert WebKitMediaSrc rework temporarily
Summary: [MSE][GStreamer] Revert WebKitMediaSrc rework temporarily
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-17 01:23 PDT by Alicia Boya García
Modified: 2019-10-21 06:29 PDT (History)
20 users (show)

See Also:

Attachments
Patch (167.45 KB, patch)
2019-10-17 03:54 PDT, Alicia Boya García 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2019-10-17 01:23:09 PDT 
While the WebKitMediaSrc rework fixed a number of tests and introduced design improvements in MSE, it also exposed a number of bugs related to the playbin3 switch.

Fixing these has been turned tricky, so in order to not keep known user-facing bugs, I'm reverting it for now until a workable solution is available.
Comment 1 Alicia Boya García 2019-10-17 03:54:51 PDT 
Created attachment 381188 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2019-10-17 04:56:41 PDT 
Is this related to bug 201824 ? Is GStreamer 1.16 still required for MSE after this patch?
Comment 3 Alicia Boya García 2019-10-18 08:34:50 PDT 
(In reply to Carlos Alberto Lopez Perez from comment #2)
> Is this related to bug 201824 ? Is GStreamer 1.16 still required for MSE
> after this patch?

It will be no longer required. But once the issues are fixed and a new iteration landed it will be required again (either that or 1.14 with appropriate backport patches).
Comment 4 WebKit Commit Bot 2019-10-21 06:28:57 PDT 
Comment on attachment 381188 [details]
Patch

Clearing flags on attachment: 381188

Committed r251365: <https://trac.webkit.org/changeset/251365>
Comment 5 WebKit Commit Bot 2019-10-21 06:29:00 PDT 
All reviewed patches have been landed.  Closing bug.