Bug 203071

Summary: Clean up some includes to improve WebKit2 build speed
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, Hironori.Fujii, jer.noble, jiewen_tan, kangil.han, krollin, philipj, sergio, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews212 for win-future
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2019-10-16 20:29:01 PDT
Clean up some includes to improve WebKit2 build speed
Attachments
Patch (28.63 KB, patch)
2019-10-16 20:30 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (28.63 KB, patch)
2019-10-16 20:38 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (28.63 KB, patch)
2019-10-16 20:43 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (27.10 KB, patch)
2019-10-16 21:31 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (27.59 KB, patch)
2019-10-16 21:51 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (27.58 KB, patch)
2019-10-16 21:59 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (28.08 KB, patch)
2019-10-16 22:20 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (28.59 KB, patch)
2019-10-16 22:52 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (31.91 KB, patch)
2019-10-19 16:22 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews212 for win-future (13.74 MB, application/zip)
2019-10-19 18:16 PDT, EWS Watchlist 		no flags
Details
Patch (32.14 KB, patch)
2019-10-19 18:28 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (33.02 KB, patch)
2019-10-19 19:17 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (33.02 KB, patch)
2019-10-19 20:03 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (34.56 KB, patch)
2019-10-19 23:28 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (35.12 KB, patch)
2019-10-20 02:06 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (35.12 KB, patch)
2019-10-20 02:23 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (35.13 KB, patch)
2019-10-20 21:51 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (35.17 KB, patch)
2019-10-20 23:10 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (16) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-10-16 20:30:39 PDT
Created attachment 381152 [details] Patch
Tim Horton
Comment 2 2019-10-16 20:38:02 PDT
Created attachment 381153 [details] Patch
Wenson Hsieh
Comment 3 2019-10-16 20:38:48 PDT
Comment on attachment 381153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381153&action=review r=mews > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:235 > +IOSurface::~IOSurface() Nit - = default?
Tim Horton
Comment 4 2019-10-16 20:43:06 PDT
Created attachment 381154 [details] Patch
Tim Horton
Comment 5 2019-10-16 21:31:21 PDT
Created attachment 381155 [details] Patch
Tim Horton
Comment 6 2019-10-16 21:51:41 PDT
Created attachment 381158 [details] Patch
Tim Horton
Comment 7 2019-10-16 21:59:16 PDT
Created attachment 381161 [details] Patch
Tim Horton
Comment 8 2019-10-16 22:20:27 PDT
Created attachment 381164 [details] Patch
Tim Horton
Comment 9 2019-10-16 22:52:40 PDT
Created attachment 381168 [details] Patch
Tim Horton
Comment 10 2019-10-16 23:35:59 PDT
I guess I should wait till I can build for iOS :|
Tim Horton
Comment 11 2019-10-19 16:22:07 PDT
Created attachment 381377 [details] Patch
EWS Watchlist
Comment 12 2019-10-19 18:16:28 PDT
Comment on attachment 381377 [details] Patch Attachment 381377 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13153497 New failing tests: http/tests/misc/repeat-open-cancel.html
EWS Watchlist
Comment 13 2019-10-19 18:16:31 PDT
Created attachment 381382 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Tim Horton
Comment 14 2019-10-19 18:28:50 PDT
Created attachment 381385 [details] Patch
Tim Horton
Comment 15 2019-10-19 19:17:52 PDT
Created attachment 381386 [details] Patch
Tim Horton
Comment 16 2019-10-19 20:03:59 PDT
Created attachment 381387 [details] Patch
Tim Horton
Comment 17 2019-10-19 23:23:21 PDT
WTF is so special about wincairo
Tim Horton
Comment 18 2019-10-19 23:28:02 PDT
Created attachment 381390 [details] Patch
Tim Horton
Comment 19 2019-10-20 02:06:05 PDT
Created attachment 381392 [details] Patch
Tim Horton
Comment 20 2019-10-20 02:23:40 PDT
Created attachment 381393 [details] Patch
Tim Horton
Comment 21 2019-10-20 21:51:31 PDT
Created attachment 381400 [details] Patch
Tim Horton
Comment 22 2019-10-20 23:10:05 PDT
Created attachment 381403 [details] Patch
Tim Horton
Comment 23 2019-10-21 00:40:55 PDT
🎉 (Can’t wait for the internal build failures to start streaming in)
WebKit Commit Bot
Comment 24 2019-10-21 01:26:03 PDT
Comment on attachment 381403 [details] Patch Clearing flags on attachment: 381403 Committed r251361: <https://trac.webkit.org/changeset/251361>
WebKit Commit Bot
Comment 25 2019-10-21 01:26:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 26 2019-10-21 01:28:44 PDT
<rdar://problem/56455005>
Note You need to log in before you can comment on or make changes to this bug.