| Summary: | Clean up some includes to improve WebKit2 build speed | ||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||||||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, dbates, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, Hironori.Fujii, jer.noble, jiewen_tan, kangil.han, krollin, philipj, sergio, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||||||||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||
|
Description
Tim Horton
2019-10-16 20:29:01 PDT
Created attachment 381152 [details]
Patch
Created attachment 381153 [details]
Patch
Comment on attachment 381153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381153&action=review r=mews > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:235 > +IOSurface::~IOSurface() Nit - = default? Created attachment 381154 [details]
Patch
Created attachment 381155 [details]
Patch
Created attachment 381158 [details]
Patch
Created attachment 381161 [details]
Patch
Created attachment 381164 [details]
Patch
Created attachment 381168 [details]
Patch
I guess I should wait till I can build for iOS :| Created attachment 381377 [details]
Patch
Comment on attachment 381377 [details] Patch Attachment 381377 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13153497 New failing tests: http/tests/misc/repeat-open-cancel.html Created attachment 381382 [details]
Archive of layout-test-results from ews212 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 381385 [details]
Patch
Created attachment 381386 [details]
Patch
Created attachment 381387 [details]
Patch
WTF is so special about wincairo Created attachment 381390 [details]
Patch
Created attachment 381392 [details]
Patch
Created attachment 381393 [details]
Patch
Created attachment 381400 [details]
Patch
Created attachment 381403 [details]
Patch
🎉 (Can’t wait for the internal build failures to start streaming in) Comment on attachment 381403 [details] Patch Clearing flags on attachment: 381403 Committed r251361: <https://trac.webkit.org/changeset/251361> All reviewed patches have been landed. Closing bug. |