Bug 203066

Summary:

Remove unused _WKProcessPoolConfiguration SPI

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	youennf: review+

Description Alex Christensen 2019-10-16 17:32:20 PDT

Remove unused _WKProcessPoolConfiguration SPI

Comment 1 Alex Christensen 2019-10-16 17:37:33 PDT

Created attachment 381139 [details]
Patch

Comment 2 Alex Christensen 2019-10-16 17:39:02 PDT

Comment on attachment 381139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381139&action=review

> Source/WebKit/ChangeLog:8
> +        After rdar://problem/56260478 this is not used, so away it goes!

(I'll wait for this radar to be integrated before landing this)

Comment 3 Alex Christensen 2019-11-12 07:18:39 PST

https://trac.webkit.org/changeset/251676/webkit

Comment 4 Radar WebKit Bug Importer 2019-11-12 07:19:20 PST

<rdar://problem/57115508>

Comment 5 Alex Christensen 2019-11-12 07:20:08 PST

Comment on attachment 381139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381139&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:-334
> -- (BOOL)suppressesConnectionTerminationOnSystemChange

This wasn't unused after all.  rdar://problem/57008444

Comment 6 Alex Christensen 2019-11-12 07:27:44 PST

http://trac.webkit.org/r252364 reverted part of this.

Comment 7 Alex Christensen 2019-11-12 07:47:33 PST

rdar://problem/57115922 tracks the revert

Comment 8 Alex Christensen 2019-11-12 09:30:26 PST

http://trac.webkit.org/r252368 reverted the rest of this.

Comment 9 Alex Christensen 2020-02-26 17:40:57 PST

This has been recommitted in https://bugs.webkit.org/show_bug.cgi?id=205751