Bug 203056

Summary: Simulator testers are filling up
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ews-watchlist, glenn, jbedard, repstein, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2019-10-16 14:51:21 PDT
Some of our simulator testers are filling up their hardrives alarmingly quickly, probably due to our habit of recreating simulators constantly. We should do some cleanup every time we tear down automatically created simulators.
Attachments
Patch (1.72 KB, patch)
2019-10-16 15:04 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-10-16 14:51:50 PDT
<rdar://problem/56344905>
Jonathan Bedard
Comment 2 2019-10-16 15:04:19 PDT
Created attachment 381119 [details] Patch
Aakash Jain
Comment 3 2019-10-30 11:40:59 PDT
Comment on attachment 381119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381119&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:483 > + for directory in host.filesystem.glob('/tmp/com.apple.CoreSimulator.SimDevice.*'): will this work fine for windows?
Jonathan Bedard
Comment 4 2019-10-30 11:44:43 PDT
Comment on attachment 381119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381119&action=review >> Tools/Scripts/webkitpy/xcode/simulated_device.py:483 >> + for directory in host.filesystem.glob('/tmp/com.apple.CoreSimulator.SimDevice.*'): > > will this work fine for windows? No, but you can't initialize simulators if you aren't on a Mac, and if we don't have initialized simulators, we early return on line 470.
WebKit Commit Bot
Comment 5 2019-10-30 12:43:42 PDT
Comment on attachment 381119 [details] Patch Clearing flags on attachment: 381119 Committed r251793: <https://trac.webkit.org/changeset/251793>
WebKit Commit Bot
Comment 6 2019-10-30 12:43:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.