Bug 203048

Summary: Rename PageCache to BackForwardCache
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, annulen, beidson, benjamin, berto, calvaris, cgarcia, cmarcelo, commit-queue, dbates, dino, dstockwell, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, ggaren, glenn, gustavo, gyuyoung.kim, hta, jamesr, japhet, jer.noble, jsbell, kangil.han, koivisto, kondapallykalyan, luiz, pdr, philipj, rakuco, ryuan.choi, sergio, simon.fraser, tommyw, tonikitoo, toyoshim, webkit-bug-importer, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202293    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-10-16 11:57:06 PDT
Rename PageCache to BackForwardCache for clarity and consistency with the UIProcess's WebBackForwardCache.
Attachments
Patch (375.91 KB, patch)
2019-10-16 14:48 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (376.59 KB, patch)
2019-10-16 15:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (378.01 KB, patch)
2019-10-16 15:53 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (378.40 KB, patch)
2019-10-16 16:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (377.94 KB, patch)
2019-10-16 17:59 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-10-16 14:48:00 PDT
Created attachment 381111 [details] Patch
EWS Watchlist
Comment 2 2019-10-16 14:48:41 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Chris Dumez
Comment 3 2019-10-16 15:00:12 PDT
Created attachment 381117 [details] Patch
Chris Dumez
Comment 4 2019-10-16 15:53:11 PDT
Created attachment 381126 [details] Patch
Chris Dumez
Comment 5 2019-10-16 16:30:05 PDT
Created attachment 381132 [details] Patch
Alex Christensen
Comment 6 2019-10-16 17:41:09 PDT
Comment on attachment 381132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381132&action=review > Source/WebCore/ChangeLog:8 > + Rename PageCache to BackForwardCache for clarity and consistency with the UIProcess's WebBackForwardCache. And Chromium!
Chris Dumez
Comment 7 2019-10-16 17:59:39 PDT
Created attachment 381143 [details] Patch
WebKit Commit Bot
Comment 8 2019-10-16 18:44:29 PDT
Comment on attachment 381143 [details] Patch Clearing flags on attachment: 381143 Committed r251220: <https://trac.webkit.org/changeset/251220>
WebKit Commit Bot
Comment 9 2019-10-16 18:44:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-10-16 18:45:19 PDT
<rdar://problem/56355134>
Note You need to log in before you can comment on or make changes to this bug.