Bug 203025 – Web Inspector: Network: updates when toggling resource caching should be sent to every connected target

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

(In reply to Joseph Pecoraro from comment <https://webkit.org/b/200384#36>)
> > Source/WebInspectorUI/UserInterface/Base/Main.js:2759
> > +    let target = WI.assumingMainTarget();
> > +    target.NetworkAgent.setResourceCachingDisabled(WI.settings.resourceCachingDisabled.value);
> 
> Whoa! NetworkAgent should work across multiple targets. So this is probably an existing bug and should just iterate all targets. (this could be pulled out into its own bug fix)
> 
>     for (let target of WI.targets) {
>         if (target.NetworkAgent)
>             target.NetworkAgent.setResourceCachingDisabled(WI.settings. resourceCachingDisabled.value);
>     }

[Devin Rousso]

Created attachment 381121 [details]
Patch

This patch requires <https://webkit.org/b/200384>.

[Joseph Pecoraro]

Comment on attachment 381121 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 381121 [details]
Patch

Clearing flags on attachment: 381121

Committed r251229: <https://trac.webkit.org/changeset/251229>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56363111>