Bug 203020

Summary: WKWebsiteDataStoreStatisticsResetToConsistentState() should call store.setUseITPDatabase(false)
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: Tools / TestsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kate Cheney
Reported 2019-10-15 18:29:53 PDT
WKWebsiteDataStoreStatisticsResetToConsistentState() should call store.setUseITPDatabase(false) between tests to keep consistent state
Attachments
Patch (197.59 KB, patch)
2019-10-16 11:57 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (14.53 KB, patch)
2019-10-16 12:31 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2019-10-15 18:30:14 PDT
<rdar://problem/56314484>
Kate Cheney
Comment 2 2019-10-16 11:57:16 PDT
Created attachment 381093 [details] Patch
Chris Dumez
Comment 3 2019-10-16 12:02:27 PDT
Comment on attachment 381093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381093&action=review > Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:1793 > +void TestRunner::setUseITPDatabase(bool value, JSValueRef completionHandler) This does not need a completion handler. It can be synchronous from TestRunner's point of view. Layout test should not have to deal with this being async. > Tools/WebKitTestRunner/TestController.cpp:3388 > + m_currentInvocation->didSetUseITPDatabase(); No need. This is called on a sync IPC from the WebContent process so once the WKBundlePostSynchronousMessage() returns, the caller can assume the operation has finished, given the runUntil() call above.
Kate Cheney
Comment 4 2019-10-16 12:31:36 PDT
Created attachment 381098 [details] Patch
Kate Cheney
Comment 5 2019-10-16 14:23:00 PDT
Thanks Chris! waiting to make sure all tests pass on the bots before asking for cq+
WebKit Commit Bot
Comment 6 2019-10-16 15:16:37 PDT
Comment on attachment 381098 [details] Patch Clearing flags on attachment: 381098 Committed r251212: <https://trac.webkit.org/changeset/251212>
WebKit Commit Bot
Comment 7 2019-10-16 15:16:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-10-16 15:17:18 PDT
<rdar://problem/56348972>
Note You need to log in before you can comment on or make changes to this bug.