Bug 202995

Summary: [Tools] Add a driver for cog for benchmark_runner.py
Product: WebKit Reporter: Pablo Saavedra <psaavedra>
Component: Tools / TestsAssignee: Pablo Saavedra <psaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue, ews-watchlist, glenn, jbedard, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Pablo Saavedra
Reported 2019-10-15 10:40:32 PDT
SSIA
Attachments
patch (3.63 KB, patch)
2019-10-15 10:51 PDT, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
patch (3.86 KB, patch)
2019-10-16 00:24 PDT, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
patch (3.84 KB, patch)
2019-10-16 04:53 PDT, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pablo Saavedra
Comment 1 2019-10-15 10:51:03 PDT
Created attachment 381000 [details] patch
Jonathan Bedard
Comment 2 2019-10-15 10:56:48 PDT
Comment on attachment 381000 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=381000&action=review > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_cog_driver.py:49 > + super(CogBrowserDriver, self).launch_url(url, options, Should be super(CogFdoBrowserDriver, ...)
Pablo Saavedra
Comment 3 2019-10-16 00:20:38 PDT
It sE1003(In reply to Jonathan Bedard from comment #2) > Comment on attachment 381000 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381000&action=review > > > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_cog_driver.py:49 > > + super(CogBrowserDriver, self).launch_url(url, options, > > Should be super(CogFdoBrowserDriver, ...) pylint is blaming against the usage of super() in the launch_url() function. I explitelly invoked the grandfathers method class to bypass the logic introduced in the CogBrowserDriver class which is the parent class. Anyway, for the sake of simplicity, I will rewrite the patch to inherit directly from the LinuxBrowserDriver. This introduces a couple of lines more but still is a simply code and probably less prone to future mistakes.
Pablo Saavedra
Comment 4 2019-10-16 00:24:23 PDT
Created attachment 381060 [details] patch
Pablo Saavedra
Comment 5 2019-10-16 04:53:17 PDT
Created attachment 381066 [details] patch
WebKit Commit Bot
Comment 6 2019-10-16 10:26:17 PDT
Comment on attachment 381066 [details] patch Clearing flags on attachment: 381066 Committed r251191: <https://trac.webkit.org/changeset/251191>
WebKit Commit Bot
Comment 7 2019-10-16 10:26:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-10-16 10:40:30 PDT
<rdar://problem/56337507>
Note You need to log in before you can comment on or make changes to this bug.