Bug 202989

Summary: Stop using inheritance for WebBackForwardCacheEntry
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, koivisto, lingcherd_ho, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202929
Bug Depends on:    
Bug Blocks: 202293    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-10-15 08:48:05 PDT
Stop using inheritance for WebBackForwardCacheEntry. This simplifies the code a bit.
Attachments
Patch (13.75 KB, patch)
2019-10-15 08:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (14.32 KB, patch)
2019-10-15 09:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (14.34 KB, patch)
2019-10-15 09:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (15.44 KB, patch)
2019-10-15 09:28 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-10-15 08:55:03 PDT
Created attachment 380988 [details] Patch
Chris Dumez
Comment 2 2019-10-15 09:09:06 PDT
Created attachment 380989 [details] Patch
Chris Dumez
Comment 3 2019-10-15 09:19:20 PDT
Created attachment 380991 [details] Patch
Chris Dumez
Comment 4 2019-10-15 09:28:21 PDT
Created attachment 380992 [details] Patch
Chris Dumez
Comment 5 2019-10-15 09:31:38 PDT
Fighting with unified build and GTK/WPE...
WebKit Commit Bot
Comment 6 2019-10-15 09:56:20 PDT
Comment on attachment 380992 [details] Patch Clearing flags on attachment: 380992 Committed r251142: <https://trac.webkit.org/changeset/251142>
WebKit Commit Bot
Comment 7 2019-10-15 09:56:22 PDT
All reviewed patches have been landed. Closing bug.
Antti Koivisto
Comment 8 2019-10-15 11:57:43 PDT
Comment on attachment 380992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380992&action=review Much better! > Source/WebKit/UIProcess/WebBackForwardCacheEntry.h:55 > + WebCore::ProcessIdentifier m_processIdentifier; > + WebCore::BackForwardItemIdentifier m_backForwardItemID; > + std::unique_ptr<SuspendedPageProxy> m_suspendedPage; If you want the get fancy you can always use Variant<> as a replacement for subclassing (maybe overkill here).
Ling Ho
Comment 9 2019-10-15 14:31:16 PDT
<rdar://problem/56295952>
Radar WebKit Bug Importer
Comment 10 2019-10-15 14:31:30 PDT
<rdar://problem/56308355>
Note You need to log in before you can comment on or make changes to this bug.