Bug 202985
| Summary: | REGRESSION (iOS 13): Invalid pictureInPictureEnabled API result | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oren Me <oren.me> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | ap, eric.carlson, jer.noble, peng.liu6 |
| Priority: | P2 | ||
| Version: | Safari 13 | ||
| Hardware: | Unspecified | ||
| OS: | iOS 13 | ||
Oren Me
Safari on iOS13 returns document.pictureInPictureEnabled as true, while it didn't on iOS12.
This breaks previous implementations where standard detection on Chrome uses document.pictureInPictureEnabled to detect support and iOS uses typeof video.webkitSupportsPresentationMode === 'function' && video.webkitSupportsPresentationMode('picture-in-picture')
now we need to do also user agent detection to exclude the document.pictureInPictureEnabled from iOS.
Is this change related to the work done for https://bugs.webkit.org/show_bug.cgi?id=201024?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
I cannot reproduce this - I get undefined on iPhone, iPad, and Mac. Also, there are no instances of "pictureInPictureEnabled" in WebKit code base.
Are you sure that it's not coming from some polyfill? If you can still reproduce, could you please attach a complete test case?
Oren Me
Alexey, you are correct, didn't even occur to me to check, but apparently Shaka player added a polyfill to patch over PiP for Safari and it adds document.pictureInPictureEnabled=true
Thanks for the quick response.