Bug 202979

Summary:

Remove duplicate MathML tests

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

MathML

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbarton, ews-watchlist, fred.wang, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Rob Buis

Reported 2019-10-15 01:26:27 PDT

Some WebKit MathML tests got imported into WPT and are now just duplicates.

Attachments
Patch (41.83 KB, patch) 2019-10-15 01:34 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (30.91 KB, patch) 2019-10-15 02:44 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (16.90 KB, patch) 2019-10-15 07:41 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (1.65 KB, patch) 2019-10-17 10:41 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (6.58 KB, patch) 2020-01-15 04:17 PST, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2019-10-15 01:34:24 PDT

Created attachment 380969 [details] Patch

Frédéric Wang (:fredw)

Comment 2 2019-10-15 01:51:36 PDT

Comment on attachment 380969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380969&action=review > LayoutTests/ChangeLog:9 > + presentation-markup/spaces/mspace-children.html. Strictly speaking, the WPT test checks that the children are not visible while the WebKit test checks that no renderers are created at all, so the latter is a bit stronger.

Rob Buis

Comment 3 2019-10-15 02:44:23 PDT

Created attachment 380976 [details] Patch

WebKit Commit Bot

Comment 4 2019-10-15 03:39:13 PDT

Comment on attachment 380976 [details] Patch Clearing flags on attachment: 380976 Committed r251130: <https://trac.webkit.org/changeset/251130>

WebKit Commit Bot

Comment 5 2019-10-15 03:39:15 PDT

All reviewed patches have been landed. Closing bug.

Rob Buis

Comment 6 2019-10-15 07:41:29 PDT

Reopening to attach new patch.

Rob Buis

Comment 7 2019-10-15 07:41:32 PDT

Created attachment 380985 [details] Patch

Radar WebKit Bug Importer

Comment 8 2019-10-15 07:41:45 PDT

<rdar://problem/56291547>

Radar WebKit Bug Importer

Comment 9 2019-10-15 07:41:47 PDT

<rdar://problem/56291548>

WebKit Commit Bot

Comment 10 2019-10-16 07:43:48 PDT

Comment on attachment 380985 [details] Patch Clearing flags on attachment: 380985 Committed r251187: <https://trac.webkit.org/changeset/251187>

WebKit Commit Bot

Comment 11 2019-10-16 07:43:50 PDT

All reviewed patches have been landed. Closing bug.

Truitt Savell

Comment 12 2019-10-17 10:14:33 PDT

It looks like in https://trac.webkit.org/changeset/251187/webkit you removed imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-form-fallback-expected.html but not the test itself which is now showing missing results in history: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fmathml%2Fpresentation-markup%2Foperators%2Fmo-form-fallback.html Can you resolve this?

Rob Buis

Comment 13 2019-10-17 10:27:47 PDT

(In reply to Truitt Savell from comment #12) > It looks like in https://trac.webkit.org/changeset/251187/webkit > > you removed > imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-form- > fallback-expected.html > > but not the test itself which is now showing missing results in history: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform- > tests%2Fmathml%2Fpresentation-markup%2Foperators%2Fmo-form-fallback.html > > Can you resolve this? Sure, will have a look.

Rob Buis

Comment 14 2019-10-17 10:41:19 PDT

Reopening to attach new patch.

Rob Buis

Comment 15 2019-10-17 10:41:21 PDT

Created attachment 381202 [details] Patch

WebKit Commit Bot

Comment 16 2019-10-17 12:23:30 PDT

Comment on attachment 381202 [details] Patch Clearing flags on attachment: 381202 Committed r251253: <https://trac.webkit.org/changeset/251253>

WebKit Commit Bot

Comment 17 2019-10-17 12:23:32 PDT

All reviewed patches have been landed. Closing bug.