Bug 202969

Summary: Add support to TextStream for dumping HashMap<> and HashSet<>
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, dino, ews-watchlist, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2019-10-14 21:26:26 PDT
Add support to TextStream for dumping HashMap<> and HashSet<>
Attachments
Patch (3.40 KB, patch)
2019-10-14 21:27 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-10-14 21:27:45 PDT
Created attachment 380960 [details] Patch
Dean Jackson
Comment 2 2019-10-15 13:42:24 PDT
Comment on attachment 380960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380960&action=review > Source/WTF/wtf/text/TextStream.h:181 > + if (item) > + return ts << item.value(); Shouldn't this make it clear that it was an optional value? e.g. item.value() << "<Opt>" or something? > Source/WTF/wtf/text/TextStream.h:207 > + for (const auto& keyValuePair : map) { Wish there were forEach-like functions on Hash*
WebKit Commit Bot
Comment 3 2019-10-19 11:40:43 PDT
Comment on attachment 380960 [details] Patch Clearing flags on attachment: 380960 Committed r251325: <https://trac.webkit.org/changeset/251325>
WebKit Commit Bot
Comment 4 2019-10-19 11:40:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-10-19 11:41:13 PDT
<rdar://problem/56436596>
Note You need to log in before you can comment on or make changes to this bug.