| Summary: | Add support to TextStream for dumping HashMap<> and HashSet<> | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, dbates, dino, ews-watchlist, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2019-10-14 21:26:26 PDT
Created attachment 380960 [details]
Patch
Comment on attachment 380960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380960&action=review > Source/WTF/wtf/text/TextStream.h:181 > + if (item) > + return ts << item.value(); Shouldn't this make it clear that it was an optional value? e.g. item.value() << "<Opt>" or something? > Source/WTF/wtf/text/TextStream.h:207 > + for (const auto& keyValuePair : map) { Wish there were forEach-like functions on Hash* Comment on attachment 380960 [details] Patch Clearing flags on attachment: 380960 Committed r251325: <https://trac.webkit.org/changeset/251325> All reviewed patches have been landed. Closing bug. |