Bug 202920

Summary: Cull inline culling
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, mifenton, mmaxfield, pdr, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 229985, 229993    
Bug Blocks:    
Attachments:
Description Flags
wip
ews-watchlist: commit-queue-
Archive of layout-test-results from ews211 for win-future
none
try
ews-feeder: commit-queue-
patch none

Description Antti Koivisto 2019-10-14 02:12:46 PDT
There is lots of complicated code to implement inline culling optimization which avoid creating lineboxes for inline containers in some situations. It doesn't seem like a meaningful optimization in modern web. Maybe we can remove it?
Comment 1 Antti Koivisto 2019-10-14 02:13:57 PDT
Created attachment 380862 [details]
wip
Comment 2 EWS Watchlist 2019-10-14 03:38:33 PDT
Comment on attachment 380862 [details]
wip

Attachment 380862 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13127454

Number of test failures exceeded the failure limit.
Comment 3 EWS Watchlist 2019-10-14 03:38:35 PDT
Created attachment 380869 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Antti Koivisto 2021-09-07 01:21:59 PDT
Created attachment 437464 [details]
try
Comment 5 Antti Koivisto 2021-09-09 07:08:32 PDT
Created attachment 437741 [details]
patch
Comment 6 EWS 2021-09-09 10:06:57 PDT
Committed r282223 (241510@main): <https://commits.webkit.org/241510@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437741 [details].
Comment 7 Radar WebKit Bug Importer 2021-09-09 10:07:30 PDT
<rdar://problem/82930911>