Bug 202918

Summary: Unify sources for bindings more densely
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, keith_miller, lingcherd_ho, sam, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2019-10-13 22:53:21 PDT
Unify sources for bindings more densely
Attachments
Patch (8.06 KB, patch)
2019-10-13 22:56 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (9.91 KB, patch)
2019-10-13 23:49 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (9.96 KB, patch)
2019-10-14 20:42 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-10-13 22:56:17 PDT
Created attachment 380856 [details] Patch
Tim Horton
Comment 2 2019-10-13 22:57:08 PDT
I'm going to fiddle some more with the constant, because I think we can even halve it and still get nearly the same speedup (which I don't totally understand, but seems to be the case). But feel free to review the rest of the patch besides that.
Tim Horton
Comment 3 2019-10-13 23:49:51 PDT
Created attachment 380858 [details] Patch
Tim Horton
Comment 4 2019-10-14 10:17:17 PDT
Comment on attachment 380858 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380858&action=review > Source/WTF/Scripts/generate-unified-source-bundles.rb:263 > + print("THORTON: #{bundleFileName()} #{bundlePrefix} #{sourceFile}\n") Whoops
Tim Horton
Comment 5 2019-10-14 20:42:56 PDT
Created attachment 380955 [details] Patch
WebKit Commit Bot
Comment 6 2019-10-14 22:53:24 PDT
Comment on attachment 380955 [details] Patch Clearing flags on attachment: 380955 Committed r251123: <https://trac.webkit.org/changeset/251123>
WebKit Commit Bot
Comment 7 2019-10-14 22:53:26 PDT
All reviewed patches have been landed. Closing bug.
Ling Ho
Comment 8 2019-10-15 14:22:30 PDT
<rdar://problem/56280139>
Note You need to log in before you can comment on or make changes to this bug.