Bug 202892

Summary: [JSC] Make ConcurrentJSLock Lock even if ENABLE_CONCURRENT_JS=OFF
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, prti, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200983
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2019-10-13 05:18:05 PDT
We are not respecting ConcurrentJS status when enabling ConcurrentGC. And concurrent GC sometimes use ConcurrentJSLock to get lock.
We should just make ConcurrentJSLock as Lock.
Comment 1 Yusuke Suzuki 2019-10-18 15:22:20 PDT
Created attachment 381338 [details]
Patch
Comment 2 Mark Lam 2019-10-18 15:28:02 PDT
Comment on attachment 381338 [details]
Patch

r=me
Comment 3 Yusuke Suzuki 2019-10-18 16:32:09 PDT
Committed r251307: <https://trac.webkit.org/changeset/251307>
Comment 4 Radar WebKit Bug Importer 2019-10-18 16:33:17 PDT
<rdar://problem/56424123>
Comment 5 Yusuke Suzuki 2019-12-18 18:19:28 PST
*** Bug 200983 has been marked as a duplicate of this bug. ***