Bug 202856

Summary: Update build.webkit.org basedir
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Aakash Jain
Reported 2019-10-11 11:09:32 PDT
In https://trac.webkit.org/r245359 build.webkit.org started using Tools/BuildSlaveSupport/Shared folder. To support that the shallow checkout on build.webkit.org was moved to Tools/BuildSlaveSupport We need to update the basedir in master.cfg accordingly. It was updated locally on the build.webkit.org machine, but wasn't committed to repo yet.
Attachments
Patch (1.29 KB, patch)
2019-10-11 11:11 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (1.43 KB, patch)
2019-10-11 14:38 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-10-11 11:11:13 PDT
Created attachment 380768 [details] Patch
Aakash Jain
Comment 2 2019-10-11 14:38:55 PDT
Created attachment 380786 [details] Patch
Aakash Jain
Comment 3 2019-10-11 14:42:08 PDT
(In reply to Aakash Jain from comment #2) > Created attachment 380786 [details] > Patch Made the basedir generic. Similar to how newer versions of buildbot create this variable https://github.com/buildbot/buildbot/blob/master/master/buildbot/scripts/buildbot_tac.tmpl#L21 and similar to https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/buildbot.tac#L6
Aakash Jain
Comment 4 2019-10-11 14:47:18 PDT
Committed r251027: <https://trac.webkit.org/changeset/251027>
Radar WebKit Bug Importer
Comment 5 2019-10-15 16:43:25 PDT
<rdar://problem/56313562>
Note You need to log in before you can comment on or make changes to this bug.