Bug 202856 - Update build.webkit.org basedir
Summary: Update build.webkit.org basedir
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-11 11:09 PDT by Aakash Jain
Modified: 2019-10-15 16:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2019-10-11 11:11 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Patch (1.43 KB, patch)
2019-10-11 14:38 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-10-11 11:09:32 PDT 
In https://trac.webkit.org/r245359 build.webkit.org started using Tools/BuildSlaveSupport/Shared folder. To support that the shallow checkout on build.webkit.org was moved to Tools/BuildSlaveSupport

We need to update the basedir in master.cfg accordingly. It was updated locally on the build.webkit.org machine, but wasn't committed to repo yet.
Comment 1 Aakash Jain 2019-10-11 11:11:13 PDT 
Created attachment 380768 [details]
Patch
Comment 2 Aakash Jain 2019-10-11 14:38:55 PDT 
Created attachment 380786 [details]
Patch
Comment 3 Aakash Jain 2019-10-11 14:42:08 PDT 
(In reply to Aakash Jain from comment #2)
> Created attachment 380786 [details]
> Patch

Made the basedir generic. Similar to how newer versions of buildbot create this variable https://github.com/buildbot/buildbot/blob/master/master/buildbot/scripts/buildbot_tac.tmpl#L21 and similar to https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/buildbot.tac#L6
Comment 4 Aakash Jain 2019-10-11 14:47:18 PDT 
Committed r251027: <https://trac.webkit.org/changeset/251027>
Comment 5 Radar WebKit Bug Importer 2019-10-15 16:43:25 PDT 
<rdar://problem/56313562>