| Summary: | DOM attribute editing should be triggered on double-click (not single click) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Timothy Hatcher <timothy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aroben | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Timothy Hatcher
2008-08-04 17:22:11 PDT
(In reply to comment #0) > We should make it happen on double-click like the style editing. Double-clicking already has a meaning in the DOM tree: it re-roots the tree on the element you double-clicked. We've also gotten complaints that double-click-to-edit in the Styles pane is hard to discover compared to Firebug's single-click-to-edit. So I'm not sure that making this change would be a definite win. See bug 17224 for more discussion about single- vs. double-click. Created attachment 22654 [details]
Proposed patch
(In reply to comment #1) > (In reply to comment #0) > > We should make it happen on double-click like the style editing. > > Double-clicking already has a meaning in the DOM tree: it re-roots the tree on > the element you double-clicked. We've also gotten complaints that > double-click-to-edit in the Styles pane is hard to discover compared to > Firebug's single-click-to-edit. So I'm not sure that making this change would > be a definite win. > > See bug 17224 for more discussion about single- vs. double-click. We are already doing different things for double-click. In TOT, when double-clicking a DOM attribute we stay in the editing mode that was started with the first click. So you already have to double click the empty space or the tag name. I also wasn't the only one to voice concern for the single click to edit behavior in bug 17224. Matt Lilek (pewtermoose) also thought it would be annoying. I think this is just one case where we are different than Firebug. I can't really think of any other single-click-to-edit designs. Comment on attachment 22654 [details]
Proposed patch
r=me
|