Summary: | [GTK][WPE] Support Pointer Events | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | WebKitGTK | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | annulen, bugs-noreply, cdumez, cgarcia, clopez, commit-queue, dino, ews-watchlist, ggaren, graouts, gyuyoung.kim, ryuan.choi, sergio | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=195008 https://bugs.webkit.org/show_bug.cgi?id=204115 https://bugs.webkit.org/show_bug.cgi?id=204157 https://bugs.webkit.org/show_bug.cgi?id=207701 https://bugs.webkit.org/show_bug.cgi?id=214870 |
||||||||
Bug Depends on: | 203996 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2019-10-10 03:12:29 PDT
I have put here some basic demos about this API: https://people.igalia.com/clopez/wkbug/pointer-events/ Support for it can be enabled for GTK and WPE and it works, but currently it only works with pointerType=mouse. If a touch device is present, it doesn't work as expected (no pressure report,etc) and it reports the pointerType as mouse. I think we can enable this as an experimental feature for the meantime. It should not be promoted to be enabled by default until it can fully replace the alternative API (MouseEvent+TouchEvent) Created attachment 383129 [details]
Patch
Comment on attachment 383129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383129&action=review > LayoutTests/platform/gtk/TestExpectations:4016 > +# PointerEvents currently only supports mouse on WTK (no Touch/Pen support) WTK -> WTR > LayoutTests/platform/gtk/TestExpectations:4025 > +imported/w3c/web-platform-tests/pointerevents/pointerevent_change-touch-action-onpointerdown_touch.html [ Skip ] > +imported/w3c/web-platform-tests/pointerevents/pointerevent_pointercancel_touch.html [ Skip ] > +imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerleave_after_pointercancel_touch.html [ Skip ] > +imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerout_after_pointercancel_touch.html [ Skip ] > +imported/w3c/web-platform-tests/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch.html [ Skip ] > +imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-auto-css_touch.html [ Skip ] > +imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch.html [ Skip ] > +imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch.html [ Skip ] > +imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerout_pen.html [ Skip ] Should we open a bug? (In reply to Carlos Garcia Campos from comment #3) > Comment on attachment 383129 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383129&action=review > > > LayoutTests/platform/gtk/TestExpectations:4016 > > +# PointerEvents currently only supports mouse on WTK (no Touch/Pen support) > > WTK -> WTR > > > LayoutTests/platform/gtk/TestExpectations:4025 > > +imported/w3c/web-platform-tests/pointerevents/pointerevent_change-touch-action-onpointerdown_touch.html [ Skip ] > > +imported/w3c/web-platform-tests/pointerevents/pointerevent_pointercancel_touch.html [ Skip ] > > +imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerleave_after_pointercancel_touch.html [ Skip ] > > +imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerout_after_pointercancel_touch.html [ Skip ] > > +imported/w3c/web-platform-tests/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch.html [ Skip ] > > +imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-auto-css_touch.html [ Skip ] > > +imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch.html [ Skip ] > > +imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch.html [ Skip ] > > +imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerout_pen.html [ Skip ] > > Should we open a bug? Right, opened bug 204115 Created attachment 383355 [details]
Patch
patch for landing
Comment on attachment 383355 [details] Patch Clearing flags on attachment: 383355 Committed r252366: <https://trac.webkit.org/changeset/252366> All reviewed patches have been landed. Closing bug. |