Bug 202779

Summary: [Mac] Update fast/text/font-cursive-italic-cjk-2.html for Catalina
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dino, jonlee, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review+

Myles C. Maxfield
Reported 2019-10-09 19:28:12 PDT
[Mac] Update fast/text/font-cursive-italic-cjk-2.html for Catalina
Attachments
Patch (4.17 KB, patch)
2019-10-09 19:29 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (2.25 KB, patch)
2019-10-10 11:47 PDT, Myles C. Maxfield 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2019-10-09 19:29:21 PDT
Created attachment 380601 [details] Patch
Myles C. Maxfield
Comment 2 2019-10-09 19:29:24 PDT
<rdar://problem/54317204>
Alexey Proskuryakov
Comment 3 2019-10-09 21:00:08 PDT
Comment on attachment 380601 [details] Patch I suggest adding a new test alongside the old one. The platform directory is really only for expectations, as putting tests there often results in a lot of confusion about where to put their results (admittedly not an issue for this reftest, but nonetheless).
Myles C. Maxfield
Comment 4 2019-10-10 11:47:21 PDT
Created attachment 380667 [details] Patch
Alexey Proskuryakov
Comment 5 2019-10-10 22:17:09 PDT
Comment on attachment 380667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380667&action=review > LayoutTests/platform/mac/TestExpectations:1173 > +[ Catalina+ ] fast/text/font-cursive-italic-cjk-2.html [ ImageOnlyFailure ] May be worth adding a comment saying that this test can be deleted when Catalina is the oldest supported OS.
Myles C. Maxfield
Comment 6 2019-10-14 13:52:29 PDT
Committed r251092: <https://trac.webkit.org/changeset/251092>
Myles C. Maxfield
Comment 7 2019-10-14 17:59:55 PDT
Committed r251115: <https://trac.webkit.org/changeset/251115>
Note You need to log in before you can comment on or make changes to this bug.