Bug 202763

Summary: [WinCairo] Move remote communication handling from RemoteInspectorServer to RemoteInspector.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, chris.reid, commit-queue, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
none
PATCH
ross.kirsling: review+
PATCH none

Basuke Suzuki
Reported 2019-10-09 13:13:22 PDT
Because RemoteInspector now exists in UIProcess, the old method which communicate with RemoteInspector in WebProcess and RemoteInspectorServer in UIProcess was meaningless or even bad. Remove this complex implementation and move communication handling from RemoteInspectorServer to directly RemoteInspector.
Attachments
PATCH (41.18 KB, patch)
2019-10-09 14:49 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (41.18 KB, patch)
2019-10-09 15:02 PDT, Basuke Suzuki 		ross.kirsling: review+
DetailsFormatted DiffDiff
PATCH (41.13 KB, patch)
2019-10-10 13:33 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2019-10-09 14:49:00 PDT
Created attachment 380568 [details] PATCH
Basuke Suzuki
Comment 2 2019-10-09 15:02:00 PDT
Created attachment 380575 [details] PATCH style fix
Ross Kirsling
Comment 3 2019-10-09 18:23:06 PDT
Comment on attachment 380575 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=380575&action=review > Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.cpp:32 > + Nit: You don't need a newline here (since it's RemoteInspectorMessageParser.h, not RemoteInspectorServer.h). > Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.h:49 > + void didClose(ConnectionID) override { }; Nit: No semicolon needed. > Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:106 > +#if PLATFORM(PLAYSTATION) || PLATFORM(WIN) Maybe this should be USE(GENERIC_EVENT_LOOP) || USE(WINDOWS_EVENT_LOOP) ?
Basuke Suzuki
Comment 4 2019-10-10 13:32:08 PDT
Comment on attachment 380575 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=380575&action=review >> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.h:49 >> + void didClose(ConnectionID) override { }; > > Nit: No semicolon needed. Wow. Yes. It should be handled by style-checker! >> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:106 >> +#if PLATFORM(PLAYSTATION) || PLATFORM(WIN) > > Maybe this should be USE(GENERIC_EVENT_LOOP) || USE(WINDOWS_EVENT_LOOP) ? That's right. Actually it is handle if every port has RunLoop::iterate() like WebCore::EventLoop::cycle()
Basuke Suzuki
Comment 5 2019-10-10 13:33:44 PDT
Created attachment 380676 [details] PATCH
WebKit Commit Bot
Comment 6 2019-10-10 14:20:19 PDT
Comment on attachment 380676 [details] PATCH Clearing flags on attachment: 380676 Committed r250988: <https://trac.webkit.org/changeset/250988>
WebKit Commit Bot
Comment 7 2019-10-10 14:20:20 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-10-10 14:21:23 PDT
<rdar://problem/56169349>
Note You need to log in before you can comment on or make changes to this bug.