Bug 202729

Summary: Update libwebrtc third-party jsoncpp to M78
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, annulen, commit-queue, eric.carlson, ews-watchlist, gyuyoung.kim, pnormand, rakuco, ryuan.choi, sergio, tsaunier, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Integrated GTK/WPE build changes
none
Patch none

youenn fablet
Reported 2019-10-09 01:32:30 PDT
Update libwebrtc third-party jsoncpp to M78
Attachments
Patch (1.23 MB, patch)
2019-10-09 01:34 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (8.39 MB, patch)
2019-10-09 01:48 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Integrated GTK/WPE build changes (1.23 MB, patch)
2019-10-09 06:04 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (1.23 MB, patch)
2019-10-09 06:25 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-10-09 01:34:27 PDT
Created attachment 380513 [details] Patch
youenn fablet
Comment 2 2019-10-09 01:48:04 PDT
Created attachment 380515 [details] Patch
youenn fablet
Comment 3 2019-10-09 02:07:10 PDT
GTK bot seems to have some issues with jsoncpp. Any idea what might be the issue?
Philippe Normand
Comment 4 2019-10-09 02:09:45 PDT
I'll have a look.
Philippe Normand
Comment 5 2019-10-09 02:23:02 PDT
The libwebrtc CMakeLists.txt needs two changes: line ~1423: add Source/third_party/jsoncpp/generated in target_include_directories so that version.h is found line ~292: change the cpp files, should be: Source/third_party/jsoncpp/source/src/lib_json/json_reader.cpp Source/third_party/jsoncpp/source/src/lib_json/json_value.cpp
youenn fablet
Comment 6 2019-10-09 06:04:07 PDT
Created attachment 380531 [details] Integrated GTK/WPE build changes
youenn fablet
Comment 7 2019-10-09 06:04:58 PDT
(In reply to Philippe Normand from comment #5) > The libwebrtc CMakeLists.txt needs two changes: > > line ~1423: add Source/third_party/jsoncpp/generated in > target_include_directories so that version.h is found > > line ~292: change the cpp files, should be: > Source/third_party/jsoncpp/source/src/lib_json/json_reader.cpp > Source/third_party/jsoncpp/source/src/lib_json/json_value.cpp Thanks!
youenn fablet
Comment 8 2019-10-09 06:25:14 PDT
Created attachment 380532 [details] Patch
WebKit Commit Bot
Comment 9 2019-10-10 01:48:23 PDT
Comment on attachment 380532 [details] Patch Rejecting attachment 380532 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 380532, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13113674
WebKit Commit Bot
Comment 10 2019-10-10 08:56:38 PDT
Comment on attachment 380532 [details] Patch Clearing flags on attachment: 380532 Committed r250972: <https://trac.webkit.org/changeset/250972>
WebKit Commit Bot
Comment 11 2019-10-10 08:56:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2019-10-10 08:57:27 PDT
<rdar://problem/56156481>
Note You need to log in before you can comment on or make changes to this bug.