Bug 202721

Summary: Remove unified plan runtime flag
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, berto, cdumez, cgarcia, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gustavo, gyuyoung.kim, hta, jer.noble, kondapallykalyan, philipj, pnormand, sergio, tommyw, tsaunier, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 202700    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews214 for win-future
none
Patch for landing none

youenn fablet
Reported 2019-10-09 00:26:28 PDT
Remove unified plan runtime flag
Attachments
Patch (21.87 KB, patch)
2019-10-09 00:33 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (24.14 KB, patch)
2019-10-09 10:51 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews214 for win-future (14.04 MB, application/zip)
2019-10-10 01:48 PDT, EWS Watchlist 		no flags
Details
Patch for landing (22.76 KB, patch)
2019-10-10 01:51 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-10-09 00:33:11 PDT
Created attachment 380504 [details] Patch
youenn fablet
Comment 2 2019-10-09 07:44:24 PDT
I need to remove the ability to disable unified plan from glib
Philippe Normand
Comment 3 2019-10-09 07:48:10 PDT
(In reply to youenn fablet from comment #2) > I need to remove the ability to disable unified plan from glib Remove the "offending" line then?
youenn fablet
Comment 4 2019-10-09 07:49:08 PDT
(In reply to Philippe Normand from comment #3) > (In reply to youenn fablet from comment #2) > > I need to remove the ability to disable unified plan from glib > > Remove the "offending" line then? That is the plan.
Philippe Normand
Comment 5 2019-10-09 07:49:29 PDT
I don't know if anyone uses the WEBKIT_WEBRTC_DISABLE_UNIFIED_PLAN env var, but now would be a good moment to remove it, in preparation for the 2.28 releases.
youenn fablet
Comment 6 2019-10-09 10:51:00 PDT
Created attachment 380544 [details] Patch
EWS Watchlist
Comment 7 2019-10-09 10:51:38 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Geoffrey Garen
Comment 8 2019-10-09 10:59:44 PDT
Comment on attachment 380544 [details] Patch r=me
EWS Watchlist
Comment 9 2019-10-10 01:48:41 PDT
Comment on attachment 380544 [details] Patch Attachment 380544 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13113575 New failing tests: http/tests/security/same-origin-appcache-blocked.html
EWS Watchlist
Comment 10 2019-10-10 01:48:43 PDT
Created attachment 380611 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
youenn fablet
Comment 11 2019-10-10 01:51:13 PDT
Created attachment 380612 [details] Patch for landing
WebKit Commit Bot
Comment 12 2019-10-10 08:15:08 PDT
Comment on attachment 380612 [details] Patch for landing Clearing flags on attachment: 380612 Committed r250969: <https://trac.webkit.org/changeset/250969>
WebKit Commit Bot
Comment 13 2019-10-10 08:15:11 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2019-10-10 08:16:20 PDT
<rdar://problem/56155447>
Note You need to log in before you can comment on or make changes to this bug.