Bug 202703

Summary: dataLogIf should be ALWAYS_INLINE
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: Web Template FrameworkAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Robin Morisset
Reported 2019-10-08 13:19:11 PDT
We often have the following pattern: ``` static constexpr bool verbose = false; ... dataLogLnIf(verbose, "Something is happening"); ``` To make sure that these are always properly eliminated I'd like to make dataLogIf/dataLogLnIf ALWAYS_INLINE. We may as well mark the branch as UNLIKELY too, for the cases where the condition comes from Options::verboseSomething.
Attachments
Patch (1.73 KB, patch)
2019-10-08 13:21 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-10-08 13:21:35 PDT
Created attachment 380457 [details] Patch
WebKit Commit Bot
Comment 2 2019-10-08 15:16:11 PDT
Comment on attachment 380457 [details] Patch Clearing flags on attachment: 380457 Committed r250867: <https://trac.webkit.org/changeset/250867>
WebKit Commit Bot
Comment 3 2019-10-08 15:16:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-10-08 15:17:26 PDT
<rdar://problem/56094719>
Note You need to log in before you can comment on or make changes to this bug.