Summary: | Web Inspector: Canvas: don't show an empty preview for WebGPU devices | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, jonlee, mattbaker, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Devin Rousso
2019-10-07 21:00:20 PDT
Created attachment 380393 [details]
Patch
Created attachment 380394 [details]
[Image] After Patch is applied
Comment on attachment 380393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380393&action=review r=me > Source/WebInspectorUI/UserInterface/Models/Canvas.js:127 > + return true; I know this was written with future contextTypes in mind, but I'd just replace it with: return contextType !== Canvas.ContextType.WebGPU && contextType !== Canvas.ContextType.WebMetal; Comment on attachment 380393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380393&action=review >> Source/WebInspectorUI/UserInterface/Models/Canvas.js:127 >> + return true; > > I know this was written with future contextTypes in mind, but I'd just replace it with: > > return contextType !== Canvas.ContextType.WebGPU && contextType !== Canvas.ContextType.WebMetal; I personally prefer this, as it's more future-proof. Comment on attachment 380393 [details] Patch Clearing flags on attachment: 380393 Committed r250858: <https://trac.webkit.org/changeset/250858> All reviewed patches have been landed. Closing bug. |