Bug 202652

Summary: Bring up queues for Catalina
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: Tools / TestsAssignee: Matt Lewis <jlewis3>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202814
https://bugs.webkit.org/show_bug.cgi?id=202816
Attachments:
Description Flags
Patch
none
Patch jbedard: review+

Matt Lewis
Reported 2019-10-07 13:38:43 PDT
Bring up queues for Catalina
Attachments
Patch (15.01 KB, patch)
2019-10-07 13:50 PDT, Matt Lewis 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2019-10-08 11:19 PDT, Matt Lewis 		jbedard: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-10-07 13:38:55 PDT
<rdar://problem/56048776>
Matt Lewis
Comment 2 2019-10-07 13:50:24 PDT
Created attachment 380356 [details] Patch
Matt Lewis
Comment 3 2019-10-07 14:32:41 PDT
Committed r250794: <https://trac.webkit.org/changeset/250794>
Matt Lewis
Comment 4 2019-10-08 11:15:17 PDT
I forgot to add the triggerable config changes.
Matt Lewis
Comment 5 2019-10-08 11:19:24 PDT
Created attachment 380445 [details] Patch
Matt Lewis
Comment 6 2019-10-08 11:21:47 PDT
Committed r250840: <https://trac.webkit.org/changeset/250840>
Aakash Jain
Comment 7 2019-10-10 11:07:05 PDT
We also need to add mac-catalina to target_platform in https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py
Aakash Jain
Comment 8 2019-10-10 11:21:10 PDT
Comment on attachment 380445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380445&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:439 > + "builderNames": ["Apple Mojave Debug WK2 (Tests)"] This seems incorrect. It should be Catalina instead of Mojave.
Note You need to log in before you can comment on or make changes to this bug.