Bug 202645

Summary:

[GTK] Navigation gesture improvements

Product:

WebKit

Reporter:

Alice Mikhaylenko <alicem>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, cgarcia, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cgarcia: review+, cgarcia: commit-queue-
Patch	none

Description Alice Mikhaylenko 2019-10-07 11:15:53 PDT

See the patch. (Yes, name's the same as in bug 194943)

Comment 1 Alice Mikhaylenko 2019-10-07 11:23:43 PDT

Created attachment 380340 [details]
Patch

Comment 2 Carlos Garcia Campos 2019-10-08 00:46:29 PDT

Comment on attachment 380340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380340&action=review

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:184
> +        deltaX *= (double) Scrollbar::pixelsPerLineStep() / m_distance;

I know this is na existing issue, but please use C++ style cast.

Comment 3 Alice Mikhaylenko 2019-10-08 02:18:22 PDT

Created attachment 380416 [details]
Patch

Sure, fixed

Comment 4 WebKit Commit Bot 2019-10-08 03:03:45 PDT

Comment on attachment 380416 [details]
Patch

Clearing flags on attachment: 380416

Committed r250820: <https://trac.webkit.org/changeset/250820>

Comment 5 WebKit Commit Bot 2019-10-08 03:03:47 PDT

All reviewed patches have been landed.  Closing bug.