Bug 202645

Summary: [GTK] Navigation gesture improvements
Product: WebKit Reporter: Alice Mikhaylenko <alicem>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
cgarcia: review+, cgarcia: commit-queue-
Patch none

Alice Mikhaylenko
Reported 2019-10-07 11:15:53 PDT
See the patch. (Yes, name's the same as in bug 194943)
Attachments
Patch (5.35 KB, patch)
2019-10-07 11:23 PDT, Alice Mikhaylenko 		cgarcia: review+
cgarcia: commit-queue-
DetailsFormatted DiffDiff
Patch (5.36 KB, patch)
2019-10-08 02:18 PDT, Alice Mikhaylenko 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alice Mikhaylenko
Comment 1 2019-10-07 11:23:43 PDT
Created attachment 380340 [details] Patch
Carlos Garcia Campos
Comment 2 2019-10-08 00:46:29 PDT
Comment on attachment 380340 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380340&action=review > Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:184 > + deltaX *= (double) Scrollbar::pixelsPerLineStep() / m_distance; I know this is na existing issue, but please use C++ style cast.
Alice Mikhaylenko
Comment 3 2019-10-08 02:18:22 PDT
Created attachment 380416 [details] Patch Sure, fixed
WebKit Commit Bot
Comment 4 2019-10-08 03:03:45 PDT
Comment on attachment 380416 [details] Patch Clearing flags on attachment: 380416 Committed r250820: <https://trac.webkit.org/changeset/250820>
WebKit Commit Bot
Comment 5 2019-10-08 03:03:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.