Bug 202641

Summary: Import autofocus Web Platform Tests
Product: WebKit Reporter: Ali Juma <ajuma>
Component: New BugsAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, rniwa, tsavell, webkit-bug-importer, Yousuke.Kimoto
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202651    
Attachments:
Description Flags
WIP for EWS
none
Patch none

Ali Juma
Reported 2019-10-07 10:30:39 PDT
Import autofocus Web Platform Tests
Attachments
WIP for EWS (64.91 KB, patch)
2019-10-07 10:35 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
Patch (65.87 KB, patch)
2019-10-07 12:03 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2019-10-07 10:35:51 PDT
Created attachment 380337 [details] WIP for EWS
Ali Juma
Comment 2 2019-10-07 12:03:46 PDT
Created attachment 380343 [details] Patch
WebKit Commit Bot
Comment 3 2019-10-08 06:56:57 PDT
Comment on attachment 380343 [details] Patch Clearing flags on attachment: 380343 Committed r250823: <https://trac.webkit.org/changeset/250823>
WebKit Commit Bot
Comment 4 2019-10-08 06:56:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-10-08 06:57:14 PDT
<rdar://problem/56072593>
Truitt Savell
Comment 6 2019-10-08 09:29:22 PDT
The new test imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-attribute/update-the-rendering.html added in https://trac.webkit.org/changeset/250823/webkit is failing on Mojave wk2. Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-attribute/update-the-rendering-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-attribute/update-the-rendering-actual.txt @@ -1,4 +1,4 @@ -FAIL "Flush autofocus candidates" should be happen after the first animation frame callbacks, and before a resize event in the next iteration of window event loop. assert_array_equals: lengths differ, expected 3 got 4 +FAIL "Flush autofocus candidates" should be happen after the first animation frame callbacks, and before a resize event in the next iteration of window event loop. assert_array_equals: property 0, expected "animationFrame" but got "autofocus" does this need to be marked as failing?
Ali Juma
Comment 8 2019-10-08 10:17:01 PDT
(In reply to Truitt Savell from comment #6) > The new test > imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus- > attribute/update-the-rendering.html > > added in https://trac.webkit.org/changeset/250823/webkit > > is failing on Mojave wk2. > > Diff: > --- > /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/ > imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus- > attribute/update-the-rendering-expected.txt > +++ > /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/ > imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus- > attribute/update-the-rendering-actual.txt > @@ -1,4 +1,4 @@ > > > -FAIL "Flush autofocus candidates" should be happen after the first > animation frame callbacks, and before a resize event in the next iteration > of window event loop. assert_array_equals: lengths differ, expected 3 got 4 > +FAIL "Flush autofocus candidates" should be happen after the first > animation frame callbacks, and before a resize event in the next iteration > of window event loop. assert_array_equals: property 0, expected > "animationFrame" but got "autofocus" > > > does this need to be marked as failing? Thanks, I'll update the expectations for Mojave WK2 and the other bots where this is failing.
Ali Juma
Comment 9 2019-10-08 12:00:31 PDT
(In reply to Ali Juma from comment #8) > (In reply to Truitt Savell from comment #6) > > The new test > > imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus- > > attribute/update-the-rendering.html > > > > added in https://trac.webkit.org/changeset/250823/webkit > > > > is failing on Mojave wk2. > > > > Diff: > > --- > > /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/ > > imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus- > > attribute/update-the-rendering-expected.txt > > +++ > > /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/ > > imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus- > > attribute/update-the-rendering-actual.txt > > @@ -1,4 +1,4 @@ > > > > > > -FAIL "Flush autofocus candidates" should be happen after the first > > animation frame callbacks, and before a resize event in the next iteration > > of window event loop. assert_array_equals: lengths differ, expected 3 got 4 > > +FAIL "Flush autofocus candidates" should be happen after the first > > animation frame callbacks, and before a resize event in the next iteration > > of window event loop. assert_array_equals: property 0, expected > > "animationFrame" but got "autofocus" > > > > > > does this need to be marked as failing? > > Thanks, I'll update the expectations for Mojave WK2 and the other bots where > this is failing. Turns out it's not just failing, it's also flaking. So I've updated TestExpectations in https://trac.webkit.org/changeset/250846/webkit.
Note You need to log in before you can comment on or make changes to this bug.