| Summary: | [CSS Shadow Parts] Internal shadow pseudo elements should work with ::part | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | allan.jensen, commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, rniwa, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 149443 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antti Koivisto
2019-10-06 03:09:24 PDT
Created attachment 380295 [details]
patch
Created attachment 380297 [details]
patch
Created attachment 380323 [details]
patch
Comment on attachment 380323 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=380323&action=review > LayoutTests/ChangeLog:11 > + * TestExpectations: Can we add tests for ::before & ::after? > Can we add tests for ::before & ::after?
They are already tested by a WPT test (and unaffected by this patch). I'll land some more tests separately.
(In reply to Antti Koivisto from comment #5) > > Can we add tests for ::before & ::after? > > They are already tested by a WPT test (and unaffected by this patch). I'll > land some more tests separately. Nice! Comment on attachment 380323 [details] patch Clearing flags on attachment: 380323 Committed r250817: <https://trac.webkit.org/changeset/250817> All reviewed patches have been landed. Closing bug. |