Bug 202606

Summary: [perf dashboard] Test fressness popover sometimes point to wrong place
Product: WebKit Reporter: Zhifei Fang <zhifei_fang>
Component: WebKit WebsiteAssignee: Zhifei Fang <zhifei_fang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dewei_zhu, jond, rniwa, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zhifei Fang
Reported 2019-10-04 15:01:25 PDT
[perf dashboard] Test fressness popover sometimes point to wrong place
Attachments
Patch (5.03 KB, patch)
2019-10-04 15:04 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (4.87 KB, patch)
2019-10-04 17:28 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zhifei Fang
Comment 1 2019-10-04 15:04:24 PDT
Created attachment 380257 [details] Patch
Zhifei Fang
Comment 2 2019-10-04 15:05:39 PDT
This patch need this: https://bugs.webkit.org/show_bug.cgi?id=202602
Ryosuke Niwa
Comment 3 2019-10-04 17:16:04 PDT
Comment on attachment 380257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380257&action=review > Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:350 > + #tooltip-container { > + position: relative; > + } Do we really need this position: relative? #tooltip-anchor being position: absolute should be sufficient, no?
Zhifei Fang
Comment 4 2019-10-04 17:28:41 PDT
Created attachment 380272 [details] Patch
Zhifei Fang
Comment 5 2019-10-04 17:29:13 PDT
(In reply to Ryosuke Niwa from comment #3) > Comment on attachment 380257 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380257&action=review > > > Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:350 > > + #tooltip-container { > > + position: relative; > > + } > > Do we really need this position: relative? > #tooltip-anchor being position: absolute should be sufficient, no? Right, https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block I think we don't need this.
WebKit Commit Bot
Comment 6 2019-10-04 18:17:05 PDT
Comment on attachment 380272 [details] Patch Clearing flags on attachment: 380272 Committed r250760: <https://trac.webkit.org/changeset/250760>
WebKit Commit Bot
Comment 7 2019-10-04 18:17:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-10-04 18:18:16 PDT
<rdar://problem/56001218>
Note You need to log in before you can comment on or make changes to this bug.