Bug 202593

Summary: Allow using WebGL 2 when USE_ANGLE=1
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198948    
Attachments:
Description Flags
Allow using WebGL 2 when USE_ANGLE=1
none
Fix USE macro none

James Darpinian
Reported 2019-10-04 12:23:05 PDT
Allow using WebGL 2 when USE_ANGLE=1
Attachments
Allow using WebGL 2 when USE_ANGLE=1 (3.30 KB, patch)
2019-10-04 12:26 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Fix USE macro (3.31 KB, patch)
2019-10-04 12:34 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2019-10-04 12:26:02 PDT
Created attachment 380232 [details] Allow using WebGL 2 when USE_ANGLE=1
Dean Jackson
Comment 2 2019-10-04 12:30:52 PDT
Comment on attachment 380232 [details] Allow using WebGL 2 when USE_ANGLE=1 View in context: https://bugs.webkit.org/attachment.cgi?id=380232&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:614 > +#if ENABLE(WEBGL2) && PLATFORM(MAC) && !USE_ANGLE !USE(ANGLE)
James Darpinian
Comment 3 2019-10-04 12:34:24 PDT
Created attachment 380234 [details] Fix USE macro
WebKit Commit Bot
Comment 4 2019-10-04 12:57:26 PDT
Comment on attachment 380234 [details] Fix USE macro Clearing flags on attachment: 380234 Committed r250740: <https://trac.webkit.org/changeset/250740>
WebKit Commit Bot
Comment 5 2019-10-04 12:57:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-10-04 12:58:15 PDT
<rdar://problem/55992173>
Note You need to log in before you can comment on or make changes to this bug.