Bug 202593

Summary: Allow using WebGL 2 when USE_ANGLE=1
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198948    
Attachments:
Description Flags
Allow using WebGL 2 when USE_ANGLE=1
none
Fix USE macro none

Description James Darpinian 2019-10-04 12:23:05 PDT
Allow using WebGL 2 when USE_ANGLE=1
Comment 1 James Darpinian 2019-10-04 12:26:02 PDT
Created attachment 380232 [details]
Allow using WebGL 2 when USE_ANGLE=1
Comment 2 Dean Jackson 2019-10-04 12:30:52 PDT
Comment on attachment 380232 [details]
Allow using WebGL 2 when USE_ANGLE=1

View in context: https://bugs.webkit.org/attachment.cgi?id=380232&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:614
> +#if ENABLE(WEBGL2) && PLATFORM(MAC) && !USE_ANGLE

!USE(ANGLE)
Comment 3 James Darpinian 2019-10-04 12:34:24 PDT
Created attachment 380234 [details]
Fix USE macro
Comment 4 WebKit Commit Bot 2019-10-04 12:57:26 PDT
Comment on attachment 380234 [details]
Fix USE macro

Clearing flags on attachment: 380234

Committed r250740: <https://trac.webkit.org/changeset/250740>
Comment 5 WebKit Commit Bot 2019-10-04 12:57:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-10-04 12:58:15 PDT
<rdar://problem/55992173>