Bug 202563

Summary:

[WebAuthn] Supply FrameInfo in -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebKit Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alex.gaynor, bfulgham, jiewen_tan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

202559

Bug Blocks:

181943

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	bfulgham: review+

Jiewen Tan

Reported 2019-10-03 22:42:24 PDT

Supply FrameInfo in -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:].

Attachments
Patch (11.15 KB, patch) 2019-10-22 03:14 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Patch (29.99 KB, patch) 2019-10-22 16:30 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Patch (30.17 KB, patch) 2019-10-22 23:08 PDT, Jiewen Tan	bfulgham: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-10-03 22:42:48 PDT

<rdar://problem/55973968>

Jiewen Tan

Comment 2 2019-10-22 03:14:33 PDT

Created attachment 381534 [details] Patch

Jiewen Tan

Comment 3 2019-10-22 16:30:10 PDT

Created attachment 381625 [details] Patch

Jiewen Tan

Comment 4 2019-10-22 22:49:27 PDT

This patch here conflicts with Bug 202561 on some minor ways. Will rebase it depending on which one get landed first.

Jiewen Tan

Comment 5 2019-10-22 23:08:20 PDT

Created attachment 381659 [details] Patch

Brent Fulgham

Comment 6 2019-10-23 08:44:21 PDT

Comment on attachment 381659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381659&action=review I have some minor suggestions, but overall looks good! r=me > Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:74 > + }, [&](const ExceptionData& exception) { It looks like you have two spaces between 'const' and 'ExceptionData&'. > Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:47 > +void WebAuthenticatorCoordinator::makeCredential(const Frame& frame, const SecurityOrigin& origin, const Vector<uint8_t>& hash, const PublicKeyCredentialCreationOptions& options, RequestCompletionHandler&& handler) Since origin and hash are coming from the message passing, I wonder if they could be WTFMove'd? Surely the hash would be worth moving.

Jiewen Tan

Comment 7 2019-10-23 12:33:00 PDT

Comment on attachment 381659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381659&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:74 >> + }, [&](const ExceptionData& exception) { > > It looks like you have two spaces between 'const' and 'ExceptionData&'. Fixed. >> Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:47 >> +void WebAuthenticatorCoordinator::makeCredential(const Frame& frame, const SecurityOrigin& origin, const Vector<uint8_t>& hash, const PublicKeyCredentialCreationOptions& options, RequestCompletionHandler&& handler) > > Since origin and hash are coming from the message passing, I wonder if they could be WTFMove'd? Surely the hash would be worth moving. This is actually for sending the message, and therefore && will do nothing here.

Jiewen Tan

Comment 8 2019-10-23 12:36:50 PDT

Committed r251489: <https://trac.webkit.org/changeset/251489>

Note You need to log in before you can comment on or make changes to this bug.