Summary: | [WebAuthn] Move the mock testing entrance to Internals | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||||||||||
Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | alex.gaynor, bfulgham, cdumez, commit-queue, jiewen_tan, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 182769, 202565 | ||||||||||||||||
Attachments: |
|
Description
Jiewen Tan
2019-10-03 22:33:29 PDT
Created attachment 380496 [details]
Patch
Created attachment 380518 [details]
Patch
Created attachment 380520 [details]
Patch
Created attachment 380550 [details]
Patch
Created attachment 380555 [details]
Patch
Comment on attachment 380555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380555&action=review > Source/WebCore/ChangeLog:9 > + This patch moves TestRunner.setWebAuthenticationMockConfiguration to Could you please explain the motivation behind this change? I looked at the patch and it is really not obvious to me why the new approach is better, considering that you need to IPC the UIProcess from WebCore using the ChromeClient now. TestRunner makes the IPC to the UIProcess trivial for you. (In reply to Chris Dumez from comment #7) > Comment on attachment 380555 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380555&action=review > > > Source/WebCore/ChangeLog:9 > > + This patch moves TestRunner.setWebAuthenticationMockConfiguration to > > Could you please explain the motivation behind this change? I looked at the > patch and it is really not obvious to me why the new approach is better, > considering that you need to IPC the UIProcess from WebCore using the > ChromeClient now. > TestRunner makes the IPC to the UIProcess trivial for you. I need to use the mock infrastructure in API tests. I should add it to the ChangeLog. Comment on attachment 380555 [details]
Patch
r=me but please improve change log before landing.
Created attachment 380572 [details]
Patch for landing
(In reply to Chris Dumez from comment #9) > Comment on attachment 380555 [details] > Patch > > r=me but please improve change log before landing. Thanks, Chris. Fixed the ChangeLog. Comment on attachment 380572 [details] Patch for landing Clearing flags on attachment: 380572 Committed r250940: <https://trac.webkit.org/changeset/250940> |