Bug 202559

Summary: [WebAuthn] Implement _WKWebAuthenticationPanel SPI
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, ggaren, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943, 191523, 200932, 202563    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Jiewen Tan 2019-10-03 21:45:21 PDT 
Implement _WKWebAuthenticationPanel SPI.
Comment 1 Jiewen Tan 2019-10-03 21:45:48 PDT 
<rdar://problem/55932094>
Comment 2 Jiewen Tan 2019-10-03 23:42:41 PDT 
Created attachment 380191 [details]
Patch
Comment 3 Jiewen Tan 2019-10-04 01:31:46 PDT 
Created attachment 380196 [details]
Patch
Comment 4 Jiewen Tan 2019-10-04 02:08:26 PDT 
Created attachment 380201 [details]
Patch
Comment 5 Brent Fulgham 2019-10-04 09:01:59 PDT 
Comment on attachment 380201 [details]
Patch

Looks good. Thank you for writing tests!
Comment 6 Jiewen Tan 2019-10-04 09:19:31 PDT 
Comment on attachment 380201 [details]
Patch

Thanks, Brent.
Comment 7 WebKit Commit Bot 2019-10-04 09:50:08 PDT 
Comment on attachment 380201 [details]
Patch

Clearing flags on attachment: 380201

Committed r250729: <https://trac.webkit.org/changeset/250729>
Comment 8 WebKit Commit Bot 2019-10-04 09:50:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Jiewen Tan 2019-10-04 15:22:57 PDT 
A build fix is landed:
Committed r250751: <https://trac.webkit.org/changeset/250751>
Comment 10 Alex Christensen 2019-10-04 15:31:58 PDT 
Another build fix is needed for the use of API::WebAuthenticationPanel in _WKWebAuthenticationPanelInternal.h
Comment 11 Alex Christensen 2019-10-04 15:36:47 PDT 
Never mind.  I think Jiewen's build fix was sufficient.