Bug 202553

Summary: Move WKProcessPool._registerURLSchemeServiceWorkersCanHandle to _WKWebsiteDataStoreConfiguration
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202850
Attachments:
Description Flags
Patch
none
Patch youennf: review+

Alex Christensen
Reported 2019-10-03 17:50:13 PDT
Move WKProcessPool._registerURLSchemeServiceWorkersCanHandle to _WKWebsiteDataStoreConfiguration
Attachments
Patch (69.33 KB, patch)
2019-10-03 17:52 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (69.25 KB, patch)
2019-10-03 18:03 PDT, Alex Christensen 		youennf: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-10-03 17:52:24 PDT
Created attachment 380171 [details] Patch
Alex Christensen
Comment 2 2019-10-03 18:03:57 PDT
Created attachment 380175 [details] Patch
youenn fablet
Comment 3 2019-10-04 07:54:25 PDT
Comment on attachment 380175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380175&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2429 > +void NetworkProcess::addServiceWorkerSession(PAL::SessionID sessionID, bool processTerminationDelayEnabled, HashSet<String>&& registeredSchemes, String& serviceWorkerRegistrationDirectory, const SandboxExtension::Handle& handle) Seems strange to have a String& serviceWorkerRegistrationDirectory. I guess this would be a String&& ideally. > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:489 > + [dataStore removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() { It might be good to leave a test using the default data store.
Alex Christensen
Comment 4 2019-10-04 09:43:36 PDT
Done, and done! http://trac.webkit.org/r250728
Radar WebKit Bug Importer
Comment 5 2019-10-04 09:44:19 PDT
<rdar://problem/55985536>
Note You need to log in before you can comment on or make changes to this bug.