Bug 202552

Summary: ASSERTION FAILED: m_transactionOperationsInProgressQueue.first() == &operation in IDBTransaction::operationCompletedOnClient
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, commit-queue, ews-watchlist, jsbell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Sihui Liu
Reported 2019-10-03 17:46:05 PDT
If there is quota error for some request, we send back an error response immediately without dispatching a task to database thread and waiting for result from database thread. However, web process expects to receive results for request in the order of requests being sent. One simple solution is to dispatch a task with the quota error to the background thread, to make sure requests are handled in order on the background thread.
Attachments
Patch (34.04 KB, patch)
2019-10-03 17:55 PDT, Sihui Liu
no flags
Patch (35.41 KB, patch)
2019-10-03 23:26 PDT, Sihui Liu
no flags
Patch (35.89 KB, patch)
2019-10-04 10:43 PDT, Sihui Liu
no flags
Patch for landing (35.95 KB, patch)
2019-10-07 14:58 PDT, Sihui Liu
no flags
Sihui Liu
Comment 1 2019-10-03 17:55:34 PDT
Alex Christensen
Comment 2 2019-10-03 20:09:41 PDT
Code change looks good. Test needs some polish.
Sihui Liu
Comment 3 2019-10-03 23:26:06 PDT
Sihui Liu
Comment 4 2019-10-04 10:43:11 PDT
Sihui Liu
Comment 5 2019-10-07 14:58:32 PDT
Created attachment 380365 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-10-07 15:36:54 PDT
Comment on attachment 380365 [details] Patch for landing Clearing flags on attachment: 380365 Committed r250800: <https://trac.webkit.org/changeset/250800>
WebKit Commit Bot
Comment 7 2019-10-07 15:36:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-10-07 15:37:16 PDT
Note You need to log in before you can comment on or make changes to this bug.