Bug 20255

Summary: Coding style fixes to EventHandler
Product: WebKit Reporter: Joe Mason <joe>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED ---    
Severity: Minor CC: manyoso
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch to fix these problems
none
Same patch with ChangeLog eric: review-

Description Joe Mason 2008-08-01 08:39:30 PDT
Just a few misc problems I noticed when looking at EventHandler:

All of the fields are public, even though some of them have accessors!  That's just bad practice.

The comment about m_capturingMouseEventsNode in handleMousePressEvent is pretty unclear.  It took me a while to figure out what it meant.
Comment 1 Joe Mason 2008-08-01 08:40:45 PDT
Created attachment 22600 [details]
Patch to fix these problems

Attached patch adds a "private:" keyword in EventHandler.h and rewrites the comment slightly.
Comment 2 Joe Mason 2008-08-04 15:24:39 PDT
Created attachment 22642 [details]
Same patch with ChangeLog

Added ChangeLog to the patch.
Comment 3 Joe Mason 2008-08-04 15:41:51 PDT
Comment on attachment 22642 [details]
Same patch with ChangeLog

RequestEE != RequestER
Comment 4 Eric Seidel (no email) 2008-08-04 20:43:31 PDT
Comment on attachment 22642 [details]
Same patch with ChangeLog

They're already private. :)